Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow typescript v5 #498

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

allow typescript v5 #498

wants to merge 1 commit into from

Conversation

osdiab
Copy link

@osdiab osdiab commented Nov 7, 2023

You might find our contributing section about Submitting Pull Requests helpful.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and verify the project with pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpx changeset and following the prompts. All changesets should be patch until Twind 1.0

just allows typescript v5 to be used. closes #497 , didn't try it out to see if typescript v5 has any issues with this though i doubt it.

@osdiab osdiab requested a review from sastan as a code owner November 7, 2023 07:07
Copy link

stackblitz bot commented Nov 7, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

codesandbox bot commented Nov 7, 2023

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

Copy link

changeset-bot bot commented Nov 7, 2023

⚠️ No Changeset found

Latest commit: 991cfdc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@PatrickJS-kunaico
Copy link

can we get this merged

@neilfranci
Copy link

when this will be merged?

@PatrickJS
Copy link

so you can can use "overrides" in package.json but we decided to go another direction. This problem definitely made us question using twind since it doesn't look to be maintained anymore

@kasvith
Copy link

kasvith commented Apr 3, 2024

Hi @PatrickJS what was your solution? twin.macro?

@PatrickJS
Copy link

@kasvith my solution was to migrate off since the project isn't maintained anymore. StyleX has a tw-to-stylex https://github.com/nmn/tw-to-stylex and @nmn is happy to help 😁

@kasvith
Copy link

kasvith commented Apr 3, 2024

Hi @PatrickJS

thanks for suggestion, im using solidjs wondering whether it will work same

@nmn
Copy link

nmn commented Apr 4, 2024

@kasvith yup. Solidjs is fully supported with StyleX. There are two open source Vite plugins for StyleX, but you can also try using the hand rolled plugin shared in the Qwik Example.

https://stylexjs.com/docs/learn/ecosystem/

Last I tried, there were issues with Solid Start though. I haven’t tried again in the last couple of months though.

@bottd
Copy link

bottd commented Jun 12, 2024

Hello @sastan is there any additional work required to get this change merged? Myself and others would appreciate having this issue resolved.

I see we can use npm's overrides fields, but it would be great to be able to install this library with an up-to-date toolchain! Thank you for your work 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: allow peer dep of typescript v5
7 participants