Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document Autoprefixer browserslist setting #899

Closed
maxwell opened this issue Apr 27, 2015 · 7 comments
Closed

Document Autoprefixer browserslist setting #899

maxwell opened this issue Apr 27, 2015 · 7 comments
Assignees
Labels

Comments

@maxwell
Copy link

maxwell commented Apr 27, 2015

I noticed that the minified bootstrap.min.css from getbootstrap.com includes a rule:

*{
  -moz-box-sizing:border-box;
}

to help with old Firefox shenanigans. (in this case, I was using Firefox 10 ::shudders::)

When I included

@import "bootstrap-sprockets";
@import "bootstrap";

in my app, that declaration was missing.

adding it back in manually made columns work as I expected.

Thanks for bootstrap-sass! It is fantastic and I love using it.

@cvrebert
Copy link
Collaborator

cvrebert commented May 6, 2015

Did you setup Autoprefixer, as mentioned in the README?

@cvrebert
Copy link
Collaborator

cvrebert commented May 6, 2015

Also, what are you using to compile the Sass code?

@maxwell
Copy link
Author

maxwell commented May 6, 2015

Howdy!

I am just using the RoR instructions here:

gem 'bootstrap-sass', '~> 3.3.4'
gem 'sass-rails', '>= 3.2'
// "bootstrap-sprockets" must be imported before "bootstrap" and "bootstrap/variables"
@import "bootstrap-sprockets";
@import "bootstrap";

Do I have to do something extra to use autoprefixer? is it not vendored with the sass includes?

@glebm
Copy link
Member

glebm commented May 6, 2015

Autoprefixer is set up by default on Rails (it's a dependency of the bootstrap-sass gem), but you may need to specify the browser versions. See autoprefixer-rails documentation for reference: https://github.com/ai/autoprefixer-rails#ruby-on-rails

@cvrebert
Copy link
Collaborator

cvrebert commented May 6, 2015

And the original Sass already has this particular bit of prefix code for good measure:

@include box-sizing(border-box);


so it's strange it's not in your compiled version.

@glebm
Copy link
Member

glebm commented May 6, 2015

Autoprefixer would remove it if it is not configured to support Firefox < 29. The defaults are: > 1%, last 2 versions, Firefox ESR, Opera 12.1, so I guess this makes sense.

@cvrebert
Copy link
Collaborator

cvrebert commented May 6, 2015

Perhaps we should mention autoprefixer's browserslist file in our docs?

@glebm glebm added the docs label May 6, 2015
@cvrebert cvrebert changed the title not including old vendor prefix to fix columns for old versions of Firefox Document Autoprefixer browserslist setting Nov 25, 2015
@cvrebert cvrebert self-assigned this Nov 27, 2015
cvrebert added a commit that referenced this issue Dec 9, 2015
ElMassimo pushed a commit to SolarCS/bootstrap-sass that referenced this issue Apr 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants