Scrollspy acting up when targets are hidden

If elements are hidden using `display: none;` which are targets mapped by scrollspy, the plugin might select an incorrect or no menu item. Checking if the target is visible solved this.
twbs · Oct 22, 2013 · 5a38a57 · 5a38a57 · musukvl · Nov 21, 2014
1 parent 9673c25
commit 5a38a57
Showing 1 changed file with 1 addition and 0 deletions.
diff --git a/js/scrollspy.js b/js/scrollspy.js
@@ -62,6 +62,7 @@
 
         return ($href
           && $href.length
+          && $href.is(':visible')
           && [[ $href[offsetMethod]().top + (!$.isWindow(self.$scrollElement.get(0)) && self.$scrollElement.scrollTop()), href ]]) || null
       })
       .sort(function (a, b) { return a[0] - b[0] })