Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider integrating visual regression testing #11410

Closed
cvrebert opened this issue Nov 8, 2013 · 13 comments
Closed

Consider integrating visual regression testing #11410

cvrebert opened this issue Nov 8, 2013 · 13 comments

Comments

@cvrebert
Copy link
Collaborator

cvrebert commented Nov 8, 2013

Via e.g.

For storing the images, http://git-annex.branchable.com/special_remotes/ ?

For visual diff inspection, http://huddle.github.io/Resemble.js/ ?

@mdo
Copy link
Member

mdo commented Jan 11, 2014

Still thinking we need this or should we pass? Seems the options have been rather limited since originally opening this issue.

@cvrebert
Copy link
Collaborator Author

It's still on my radar, but there's no definite timeline. Punted to the next milestone for now.

@cvrebert
Copy link
Collaborator Author

Okay, we have https://github.com/cvrebert/grunt-sauce-screenshots to take the screenshots, and a Python script to upload them to S3.
Now we just need a web app to run the comparisons and let humans review+approve differences as they arise.

@XhmikosR
Copy link
Member

@cvrebert
Copy link
Collaborator Author

@XhmikosR (a) That doesn't seem to be cross-browser (b) We just need generic image comparison, since we already have something to take the screenshot images in the first place.

@XhmikosR
Copy link
Member

That compares 2 pages itself; it runs in node.js. I haven't used it myself just thought it might help.

@cvrebert cvrebert modified the milestones: v3.2.0, v3.1.1 Feb 9, 2014
@mdo
Copy link
Member

mdo commented Mar 10, 2014

Anyone want to own this? If not, I'll say fuck it and pass.

@cvrebert cvrebert removed this from the v3.2.0 milestone Mar 10, 2014
@cvrebert
Copy link
Collaborator Author

I own this. Gonna punt it to post-3.2.

@mdo
Copy link
Member

mdo commented Mar 10, 2014

My man. <3

@thomaswelton
Copy link
Contributor

I'd be interested to see which direction you go with this.
On development on a new company frontend toolkit we have visual regression testing where we are using https://github.com/Huddle/PhantomCSS in full. And also using PhantomCSS just to do the visual diff comparisons (the screenshots are taken in java using Selenium)

But https://github.com/cvrebert/grunt-sauce-screenshots looks good.

@mdo
Copy link
Member

mdo commented Jul 24, 2014

Closing this because it's been forever and it's a nice-to-have thing.

@mdo mdo closed this as completed Jul 24, 2014
cvrebert referenced this issue Nov 17, 2014
Only used for the GitHub docs.

```
about/index.html 17.63 kB → 14.5 kB
browser-bugs/index.html 16.98 kB → 13.68 kB
components/index.html 278.95 kB → 239.71 kB
css/index.html 289.85 kB → 260.57 kB
customize/index.html 129.39 kB → 110.46 kB
getting-started/index.html 64.4 kB → 58.27 kB
index.html 11.78 kB → 9.74 kB
javascript/index.html 196.35 kB → 173.8 kB
migration/index.html 25.02 kB → 18.99 kB
```
@markelog
Copy link

markelog commented Feb 1, 2015

Prompted by discussion in jquery chassis repo - jquery-archive/css-chassis#25

It seems @cvrebert and i indentified two candidates for this task: Gemini and WebdriverCSS. Both provide same amount of features, but in different ways.

@mdo if you still interested in this and if @cvrebert doesn't mind, i'd like to volunteer to try my luck with gemini. If implementation would be successful, it could create a good example of how this could be done for chassis and topcoat frameworks.

You can get the idea of the end result with this repo:
config - https://github.com/bem/bem-components/blob/v2/.gemini.yml
test example - https://github.com/bem/bem-components/blob/v2/gemini/button.gemini.js
screenshots example - https://github.com/bem/bem-components/tree/v2/gemini/screens/button

What do you think?

@cvrebert
Copy link
Collaborator Author

cvrebert commented Feb 4, 2015

I don't mind at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants