-
-
Notifications
You must be signed in to change notification settings - Fork 78.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider integrating visual regression testing #11410
Comments
Still thinking we need this or should we pass? Seems the options have been rather limited since originally opening this issue. |
It's still on my radar, but there's no definite timeline. Punted to the next milestone for now. |
Okay, we have https://github.com/cvrebert/grunt-sauce-screenshots to take the screenshots, and a Python script to upload them to S3. |
@XhmikosR (a) That doesn't seem to be cross-browser (b) We just need generic image comparison, since we already have something to take the screenshot images in the first place. |
That compares 2 pages itself; it runs in node.js. I haven't used it myself just thought it might help. |
Anyone want to own this? If not, I'll say fuck it and pass. |
I own this. Gonna punt it to post-3.2. |
My man. <3 |
I'd be interested to see which direction you go with this. But https://github.com/cvrebert/grunt-sauce-screenshots looks good. |
Closing this because it's been forever and it's a nice-to-have thing. |
Only used for the GitHub docs. ``` about/index.html 17.63 kB → 14.5 kB browser-bugs/index.html 16.98 kB → 13.68 kB components/index.html 278.95 kB → 239.71 kB css/index.html 289.85 kB → 260.57 kB customize/index.html 129.39 kB → 110.46 kB getting-started/index.html 64.4 kB → 58.27 kB index.html 11.78 kB → 9.74 kB javascript/index.html 196.35 kB → 173.8 kB migration/index.html 25.02 kB → 18.99 kB ```
Prompted by discussion in jquery chassis repo - jquery-archive/css-chassis#25 It seems @cvrebert and i indentified two candidates for this task: Gemini and WebdriverCSS. Both provide same amount of features, but in different ways. @mdo if you still interested in this and if @cvrebert doesn't mind, i'd like to volunteer to try my luck with gemini. If implementation would be successful, it could create a good example of how this could be done for chassis and topcoat frameworks. You can get the idea of the end result with this repo: What do you think? |
I don't mind at all. |
Via e.g.
https://github.com/Huddle/PhantomCSS (Firefox + Chrome, uses PhantomJS, supposedly supports screen width tests)https://github.com/bbc-news/wraith (Firefox + Chrome, uses PhantomJS, supports screen width tests)http://browsershots.org (not fully automated, uses Selenium)https://npmjs.org/package/grunt-photobox (Chrome, uses PhantomJS, supports screen width testing)https://github.com/cburgmer/csscritic (Chrome, uses PhantomJS)https://github.com/bslatkin/dpxdthttps://github.com/garris/BackstopJSFor storing the images, http://git-annex.branchable.com/special_remotes/ ?For visual diff inspection, http://huddle.github.io/Resemble.js/ ?
The text was updated successfully, but these errors were encountered: