Give all embedded live docs examples data-example-id attrs #15214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not going to be possible come v4 without some extra work sadly given the custom examples snippet doodad I cooked up. |
|
It should be possible to rejigger the whatchamacallit to make it work. I'll take a look. |
|
@cvrebert Right on. Follow your heart then on this PR <3. |
|
The doodad has been tweaked to support example IDs, and I volunteer to perform the merge of this PR into the v4 branch when necessary. So, gonna merge this into v3. |
cvrebert
added a commit
that referenced
this pull request
Dec 5, 2014
Give all embedded live docs examples data-example-id attrs [skip sauce]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will be useful for #11410.
CC: @mdo et al.