Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customizer: Show a warning when IE <=9 or Safari is used #12617

Closed
XhmikosR opened this issue Feb 6, 2014 · 7 comments · Fixed by #12773
Closed

Customizer: Show a warning when IE <=9 or Safari is used #12617

XhmikosR opened this issue Feb 6, 2014 · 7 comments · Fixed by #12773
Labels
Milestone

Comments

@XhmikosR
Copy link
Member

XhmikosR commented Feb 6, 2014

Since the customizer doesn't work on IE <= 9 due to at least FileSaver.js, maybe we should show an extra warning there.

@cvrebert
Copy link
Collaborator

cvrebert commented Feb 6, 2014

Might also want to warn on Safari; see #12567.

@XhmikosR
Copy link
Member Author

XhmikosR commented Feb 6, 2014

Sounds good, yes.

@zlatanvasovic
Copy link
Contributor

@supergibbs
Copy link
Contributor

@zdroid For IE 9, conditional comments are pretty reliable.

http://msdn.microsoft.com/en-us/library/ms537512.ASPX

@zlatanvasovic
Copy link
Contributor

Yes, but I don't want that. I want to just add new code to the customizer.js.

@supergibbs
Copy link
Contributor

How about using the feature detection mentioned in the FileSaver.js docs? That should solve both IE9 and Safari 6
try { var isFileSaverSupported = !!new Blob(); } catch(e){}

@zlatanvasovic
Copy link
Contributor

OK, that sounds nice. ;P

2014-02-09 11:28 GMT+01:00 Jesse Mandel notifications@github.com:

How about using the feature detection mentioned in the FileSaver.js docs?
That should solve both IE9 and Safari 6
try { var isFileSaverSupported = !!new Blob(); } catch(e){}


Reply to this email directly or view it on GitHubhttps://github.com//issues/12617#issuecomment-34570387
.

Zlatan Vasović - ZDroid

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
5 participants