Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confirm that the customizer blocks IE<=9, or fix it so that it does. #13090

Closed
cvrebert opened this issue Mar 17, 2014 · 8 comments · Fixed by #13626
Closed

Confirm that the customizer blocks IE<=9, or fix it so that it does. #13090

cvrebert opened this issue Mar 17, 2014 · 8 comments · Fixed by #13626
Labels
Milestone

Comments

@cvrebert
Copy link
Collaborator

Refs #12773 (comment) & #12617.

@cvrebert
Copy link
Collaborator Author

Confirmed that IE9 is properly blocked.
IE8 however, runs into a fatal JS error.

@cvrebert
Copy link
Collaborator Author

The error seems to be in less.js's initialization.
less.js doesn't support IE8 in the first place:

Less only supports running on modern browsers (recent versions of Chrome, Firefox, Safari and IE).

@XhmikosR
Copy link
Member

So basically, there's no IE8 support in customizer.? I remember I had issues when testing stuff, but it was a long time ago.

@cvrebert
Copy link
Collaborator Author

Well, right, as the issue title says, we can't support IE8.
The difference is that with IE8 we crash without a friendly error message; on the other problematic browsers, we show a friendly error message and the JS doesn't outright crash.

@XhmikosR
Copy link
Member

Yeah, it's because of less.

So I guess we should explicitly nuke IE 8 too for customizer?

@cvrebert
Copy link
Collaborator Author

Well, ideally yes, but because it goes wrong so early, it's a bit harder than the others.
Maybe use an IE conditional HTML comment?

@XhmikosR
Copy link
Member

That should work, yeah.

@cvrebert
Copy link
Collaborator Author

Closing in favor of #13626.

@mdo mdo removed this from the v3.2.1 milestone May 23, 2014
@cvrebert cvrebert added this to the v3.2.0 milestone May 23, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants