Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LESS: .table-row-variant mixin doesn't respect @table-bg-hover variable #13530

Closed
drewbeck opened this issue May 7, 2014 · 1 comment
Closed

Comments

@drewbeck
Copy link

drewbeck commented May 7, 2014

I've got @table-bg-hover set to a color in variables.less but my color isn't being respected!

It comes down to the following code. Note where the arrow is (<--------): the :hover is being set to a darker version of @table-bg-active instead of to @table-bg-hover!

tables.less:121:

.table-hover {
  > tbody > tr:hover {
    > td,
    > th {
      background-color: @table-bg-hover;
    }
  }
}

tables.less:158:

.table-row-variant(active; @table-bg-active);

mixins.less:441:

.table-row-variant(@state; @background) {

  ... snip ...
  // Hover states for `.table-hover`
  // Note: this is not available for cells or rows within `thead` or `tfoot`.
  .table-hover > tbody > tr {
    > td.@{state}:hover,
    > th.@{state}:hover,
    &.@{state}:hover > td,
    &.@{state}:hover > th {
      background-color: darken(@background, 5%);    <-----------
    }
  }
}
@mdo
Copy link
Member

mdo commented Jun 11, 2014

Variants have their own color overrides for :hover states that are not tied to the default @table-bg-hover variable. Naturally, they should be a shade darker than the variant background color, as they are now in master.

@mdo mdo closed this as completed Jun 11, 2014
@mdo mdo removed this from the v3.2.1 milestone Jun 11, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants