Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.table-row-variant mixin respects @table-bg-hover #13530 #13598

Closed
wants to merge 1 commit into from

Conversation

tivvit
Copy link

@tivvit tivvit commented May 14, 2014

fixes #13530

@cvrebert cvrebert added the css label May 14, 2014
@cvrebert
Copy link
Collaborator

Yeah, but now you're not respecting the @background parameter of the mixin, which if anything seems worse. Don't know if there's a good solution here. Maybe deprecate @table-bg-hover and use a computed color in its place?

@tivvit
Copy link
Author

tivvit commented May 14, 2014

How about to use something like this? http://stackoverflow.com/questions/18414668/set-less-variable-if-its-not-set. Hover color will be computed if @table-bg-hover is not defined.

@cvrebert
Copy link
Collaborator

Practically speaking, @table-bg-hover will basically always be defined (at least in Bootstrap v3).

@tivvit
Copy link
Author

tivvit commented May 14, 2014

I thought about computing it's value by default. Instead of deprecating it, this wouldn't be BC break.

User can define custom color but when he doesn't default will be used.

Problem is this is not very clean, because of it is not clear there exists possibility like this, and user may be confused where this exact color appeared.

@cvrebert cvrebert added this to the v3.2.1 milestone May 23, 2014
@mdo
Copy link
Member

mdo commented Jun 11, 2014

Punting per comment in #13530.

@mdo mdo closed this Jun 11, 2014
@mdo mdo removed this from the v3.2.1 milestone Jun 11, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LESS: .table-row-variant mixin doesn't respect @table-bg-hover variable
3 participants