v4: Revamp list group items built with anchors and buttons #19103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
mdo
commented
Feb 7, 2016
mdo
commented
- Make it an explicit class instead of qualifying with elements (.list-group-item-action)
- Rearrange the entire file for more straightforward flow
- Fix text-decoration bug as a result of the reorder
- Switch from h4's to h5's in docs
- Update docs to merge anchors and buttons sections; clearify usage guidelines there, too
- Nullify Rename a.list-group-item to .list-group-item-link -- v4 #17479 in the process
- Make it an explicit class instead of qualifying with elements (.list-group-item-action) - Rearrange the entire file for more straightforward flow - Fix text-decoration bug as a result of the reorder - Switch from h4's to h5's in docs - Update docs to merge anchors and buttons sections; clearify usage guidelines there, too - Nullify #17479 in the process
mdo
added a commit
that referenced
this pull request
Feb 7, 2016
v4: Revamp list group items built with anchors and buttons
Closed
torbjoernk
added a commit
to torbjoernk/jlesc.github.io
that referenced
this pull request
Feb 23, 2016
These are mainly: - [#17194](twbs/bootstrap#17194) - [#18772](twbs/bootstrap#18772) - [#18782](twbs/bootstrap#18782) - [#19099](twbs/bootstrap#19099) - [#19102](twbs/bootstrap#19102) - [#19103](twbs/bootstrap#19103) Signed-off-by: Torbjörn Klatt <t.klatt@fz-juelich.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.