Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Wall of Browser Bugs entries for <dialog> #20175

Merged
merged 2 commits into from
Jul 8, 2016
Merged

Add Wall of Browser Bugs entries for <dialog> #20175

merged 2 commits into from
Jul 8, 2016

Conversation

cvrebert
Copy link
Collaborator

@cvrebert cvrebert commented Jun 25, 2016

I propose adding these on the grounds that <dialog> would make it much easier and less hacky to implement modals. In particular, accomplishing the "disablement" of the underlying page, so that the modal is actually modal, is currently pretty painful.

Refs:

CC: @twbs/team for review

@patrickhlauke
Copy link
Member

but as bootstrap currently doesn't use <dialog>, it's not really a bug that affects us? (except for providing a reason why we're not using it, perhaps)

@cvrebert
Copy link
Collaborator Author

Yes, it's a feature request rather than a bug per se. The reasoning is similar to #20143. <dialog> would make Bootstrap better and make our lives as maintainers easier, but lack of browser support currently prevents us from using it.

@hnrch02
Copy link
Collaborator

hnrch02 commented Jun 26, 2016

Maybe then we need to rename it? The thought crossed my mind before with #20143.

@cvrebert
Copy link
Collaborator Author

Would breaking out the feature requests into a "Most Wanted Features" section satisfy you?

@patrickhlauke
Copy link
Member

that'd work for me (or a "Why don't you folks use..." section ;) )

@hnrch02
Copy link
Collaborator

hnrch02 commented Jun 29, 2016

Sure, sounds good to me.

@cvrebert
Copy link
Collaborator Author

cvrebert commented Jul 8, 2016

@hnrch02 @patrickhlauke Updated. Does the copy read okay to you?

@patrickhlauke
Copy link
Member

LGTM

@cvrebert cvrebert merged commit 4ea33f3 into v4-dev Jul 8, 2016
@cvrebert cvrebert deleted the dialog-wall branch July 8, 2016 15:13
@hnrch02
Copy link
Collaborator

hnrch02 commented Jul 8, 2016

Late 👍 from me.

cvrebert added a commit that referenced this pull request Jul 12, 2016
[skip sauce]
cvrebert added a commit that referenced this pull request Aug 3, 2016
@VikneswaranThangarasu VikneswaranThangarasu mentioned this pull request Oct 4, 2016
hoopy pushed a commit to zBuyer/bootstrap that referenced this pull request Nov 29, 2016
MohammadYounes pushed a commit to RTLCSS/bootstrap that referenced this pull request Dec 1, 2016
@RehanSaeed
Copy link

RehanSaeed commented Jan 16, 2018

How about using something like dialog-polyfill to add support instead of Bootstrap shipping it's own implementation? There doesn't seem to be an issue for this, should I raise one?

@sassquad
Copy link

As of January 2020, support for the dialog element has expanded somewhat. Microsoft Edge has been superceded by Microsoft Edge (Chromium), while Firefox has an implementation hidden behind a config flag (although I think this was the case even 2 years ago).

The links within the Most Wanted features that refer to the element will need some updating, since the EdgeHTML links now no longer work, presumably reflecting the deprecated status of the 'old' Edge.

@XhmikosR
Copy link
Member

We no longer have the Wall of Bugs page for v5 because it was basically unmaintained. You are welcome to make a PR targeting the v4-dev branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants