-
-
Notifications
You must be signed in to change notification settings - Fork 78.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Wall of Browser Bugs entries for <dialog> #20175
Conversation
but as bootstrap currently doesn't use |
Yes, it's a feature request rather than a bug per se. The reasoning is similar to #20143. |
Maybe then we need to rename it? The thought crossed my mind before with #20143. |
Would breaking out the feature requests into a "Most Wanted Features" section satisfy you? |
that'd work for me (or a "Why don't you folks use..." section ;) ) |
Sure, sounds good to me. |
@hnrch02 @patrickhlauke Updated. Does the copy read okay to you? |
Refs https://bugzil.la/840640 Refs https://webkit.org/b/84635 [skip sauce]
LGTM |
Late 👍 from me. |
Most Wanted features: Add Edge UserVoice <dialog> entry https://wpdev.uservoice.com/forums/257854-microsoft-edge-developer/suggestions/6508895-dialog-element Refs twbs#20175 [ci skip]
Most Wanted features: Add Edge UserVoice <dialog> entry https://wpdev.uservoice.com/forums/257854-microsoft-edge-developer/suggestions/6508895-dialog-element Refs twbs#20175 [ci skip]
How about using something like dialog-polyfill to add support instead of Bootstrap shipping it's own implementation? There doesn't seem to be an issue for this, should I raise one? |
As of January 2020, support for the The links within the Most Wanted features that refer to the element will need some updating, since the EdgeHTML links now no longer work, presumably reflecting the deprecated status of the 'old' Edge. |
We no longer have the Wall of Bugs page for v5 because it was basically unmaintained. You are welcome to make a PR targeting the v4-dev branch |
I propose adding these on the grounds that
<dialog>
would make it much easier and less hacky to implement modals. In particular, accomplishing the "disablement" of the underlying page, so that the modal is actually modal, is currently pretty painful.Refs:
CC: @twbs/team for review