Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Wall of Browser Bugs entries for <dialog> #20175

Merged
merged 2 commits into from Jul 8, 2016

Conversation

Projects
None yet
4 participants
@cvrebert
Copy link
Member

cvrebert commented Jun 25, 2016

I propose adding these on the grounds that <dialog> would make it much easier and less hacky to implement modals. In particular, accomplishing the "disablement" of the underlying page, so that the modal is actually modal, is currently pretty painful.

Refs:

CC: @twbs/team for review

@cvrebert cvrebert added this to the v4.0.0-alpha.3 milestone Jun 25, 2016

@patrickhlauke

This comment has been minimized.

Copy link
Member

patrickhlauke commented Jun 26, 2016

but as bootstrap currently doesn't use <dialog>, it's not really a bug that affects us? (except for providing a reason why we're not using it, perhaps)

@cvrebert

This comment has been minimized.

Copy link
Member Author

cvrebert commented Jun 26, 2016

Yes, it's a feature request rather than a bug per se. The reasoning is similar to #20143. <dialog> would make Bootstrap better and make our lives as maintainers easier, but lack of browser support currently prevents us from using it.

@hnrch02

This comment has been minimized.

Copy link
Member

hnrch02 commented Jun 26, 2016

Maybe then we need to rename it? The thought crossed my mind before with #20143.

@cvrebert

This comment has been minimized.

Copy link
Member Author

cvrebert commented Jun 28, 2016

Would breaking out the feature requests into a "Most Wanted Features" section satisfy you?

@patrickhlauke

This comment has been minimized.

Copy link
Member

patrickhlauke commented Jun 28, 2016

that'd work for me (or a "Why don't you folks use..." section ;) )

@hnrch02

This comment has been minimized.

Copy link
Member

hnrch02 commented Jun 29, 2016

Sure, sounds good to me.

@cvrebert cvrebert force-pushed the dialog-wall branch from 1191640 to c80dfc9 Jul 8, 2016

@cvrebert

This comment has been minimized.

Copy link
Member Author

cvrebert commented Jul 8, 2016

@hnrch02 @patrickhlauke Updated. Does the copy read okay to you?

@cvrebert cvrebert force-pushed the dialog-wall branch from c80dfc9 to c5706bd Jul 8, 2016

@cvrebert cvrebert force-pushed the dialog-wall branch from c5706bd to 0b21f2e Jul 8, 2016

@patrickhlauke

This comment has been minimized.

Copy link
Member

patrickhlauke commented Jul 8, 2016

LGTM

@cvrebert cvrebert merged commit 4ea33f3 into v4-dev Jul 8, 2016

3 of 4 checks passed

savage Savage has initiated its special separate Travis CI build
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
hound No violations found. Woof!

@cvrebert cvrebert deleted the dialog-wall branch Jul 8, 2016

@hnrch02

This comment has been minimized.

Copy link
Member

hnrch02 commented Jul 8, 2016

Late 👍 from me.

cvrebert added a commit that referenced this pull request Jul 12, 2016

Port #20175 to v3
[skip sauce]

cvrebert added a commit that referenced this pull request Aug 3, 2016

@VikneswaranThangarasu VikneswaranThangarasu referenced this pull request Oct 4, 2016

Closed

V3 dev #20836

hoopy added a commit to zBuyer/bootstrap that referenced this pull request Nov 29, 2016

MohammadYounes added a commit to RTLCSS/bootstrap that referenced this pull request Dec 1, 2016

@RehanSaeed

This comment has been minimized.

Copy link

RehanSaeed commented Jan 16, 2018

How about using something like dialog-polyfill to add support instead of Bootstrap shipping it's own implementation? There doesn't seem to be an issue for this, should I raise one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.