Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add column gap size as :root variable #28936

Closed
boutzamat opened this issue Jun 20, 2019 · 4 comments
Closed

Add column gap size as :root variable #28936

boutzamat opened this issue Jun 20, 2019 · 4 comments
Labels

Comments

@boutzamat
Copy link

By adding column gap to :root variables, it will be much easier to create adaptable stylesheets that matches Bootstrap, no matter how it is customized.

@MartijnCuppens
Copy link
Member

Bootstrap supports Internet Explorer which doesn't support custom properties. We currently can't do this.

@boutzamat
Copy link
Author

But... you're already using root variables?
With that logic, we need to remove --primary, --secondary etc as well?

@MartijnCuppens
Copy link
Member

That's an enhancement we have for those who want to use those custom properties. But this might be a bit confusing indeed since we don't mention anything about IE support: https://getbootstrap.com/docs/4.3/getting-started/theming/#css-variables

Probably need to change the documentation or drop them.

Thoughts, @twbs/css-review?

@mdo
Copy link
Member

mdo commented Jul 10, 2019

We don't support any other grid variables there (largely because media queries cannot use CSS custom properties at this time). We added them before realizing that, so they've stuck around. I think given that, we'll likely keep the list of variables really small here and remove those vars before adding new ones.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants