Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.4.1] Modal doesn't close when escape key is pressed and backdrop option like 'static' #29978

Closed
mendozagioo opened this issue Jan 8, 2020 · 1 comment
Labels

Comments

@mendozagioo
Copy link
Contributor

This issue is due to a question in Slack by: Asif Qureshi.

Tested on:

  • MacOS 10.15.2
  • Firefox 72

Description:
A new documentation of v4.4.1 describe that modals doesn't close when is used backdrop option in 'static', that is correct, but only should apply when the keyboard option is false, and that is not happens, so, if you want to use keyboard option in false or true, the modal doesn't close.
The documentation also describes:

Name Type Default Description
keyboard boolean true Closes the modal when escape key is pressed

With version 4.3.1 this didn't happen

Test case:
v4.4.1: https://codepen.io/asif8q/pen/zYxRobw
v4.3.1: https://codepen.io/asif8q/pen/LYEQxYm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants