Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Close modal with keyboard=true & backdrop=static #29986

Merged
merged 3 commits into from
Jan 10, 2020
Merged

Close modal with keyboard=true & backdrop=static #29986

merged 3 commits into from
Jan 10, 2020

Conversation

mendozagioo
Copy link
Contributor

@mendozagioo mendozagioo commented Jan 8, 2020 •
edited by XhmikosR

This avoid the no close of modal with options:

$('#my-modal').modal({
backdrop: 'static',
keyboard: true
})

fix issue: #29978

Preview: https://deploy-preview-29986--twbs-bootstrap.netlify.com/docs/4.3/components/modal/#static-backdrop

@mendozagioo mendozagioo requested a review from a team as a code owner January 8, 2020 19:01
@Johann-S Johann-S added this to Inbox in v5 via automation Jan 9, 2020
@Johann-S Johann-S added this to Inbox in v4.5.0 via automation Jan 9, 2020
v5 automation moved this from Inbox to Approved Jan 9, 2020
Johann-S
Johann-S approved these changes Jan 9, 2020
View reviewed changes
Copy link
Member

@Johann-S Johann-S left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice PR thanks @mendozagioo 👍

MartijnCuppens
MartijnCuppens approved these changes Jan 9, 2020
View reviewed changes
Copy link
Member

@MartijnCuppens MartijnCuppens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work fine, thanks!

@XhmikosR
Copy link
Member

Thanks for the patch @mendozagioo!

@Johann-S this will need to be manually backported to my v4-dev-xmr branch when you have some time :)

@XhmikosR XhmikosR merged commit 954a0b1 into twbs:master Jan 10, 2020
v5 automation moved this from Approved to Shipped Jan 10, 2020
@XhmikosR XhmikosR mentioned this pull request Jan 10, 2020
Closed
@XhmikosR XhmikosR moved this from Inbox to Needs manual backport in v4.5.0 Jan 23, 2020
@XhmikosR XhmikosR mentioned this pull request Jan 23, 2020
Merged
@XhmikosR
Copy link
Member

@mendozagioo can you please backport this to my v4-dev-xmr branch?

XhmikosR pushed a commit that referenced this pull request Feb 12, 2020
@mendozagioo @XhmikosR
NEEDS TESTS
398cb07 
Close modal with keyboard=true & backdrop=static (#29986)

* Close modal with keyboard=true & backdrop=static
mendozagioo added a commit to mendozagioo/bootstrap that referenced this pull request Feb 16, 2020
@mendozagioo
Tests added to close modal
14323ff 
* According to twbs#29986
@mendozagioo
Copy link
Contributor Author

@XhmikosR, I added the appropriate tests

@mendozagioo mendozagioo mentioned this pull request Feb 16, 2020
Merged
@XhmikosR XhmikosR moved this from Needs manual backport to Cherry-picked in v4.5.0 Feb 16, 2020
@XhmikosR XhmikosR moved this from Cherry-picked to Needs manual backport in v4.5.0 Feb 16, 2020
@XhmikosR XhmikosR moved this from Needs manual backport to Cherry-picked in v4.5.0 Feb 16, 2020
@XhmikosR XhmikosR moved this from Cherry-picked to Shipped in v4.5.0 Feb 22, 2020
@VictorioBerra VictorioBerra mentioned this pull request May 20, 2020
Closed
olsza pushed a commit to olsza/bootstrap that referenced this pull request Oct 3, 2020
@mendozagioo @olsza
Close modal with keyboard=true & backdrop=static (twbs#29986)
32ed9a3 
* Close modal with keyboard=true & backdrop=static
@nelsonni nelsonni mentioned this pull request Jan 5, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Johann-S Johann-S Johann-S approved these changes

@MartijnCuppens MartijnCuppens MartijnCuppens approved these changes

Assignees
No one assigned
Labels
backport-to-v4 js v4 v5
Projects
No open projects
v4.5.0
  
Shipped
v5
  
Shipped
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mendozagioo @XhmikosR @Johann-S @MartijnCuppens