Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close modal with keyboard=true & backdrop=static #29986

Merged
merged 3 commits into from Jan 10, 2020

Conversation

@mendozagioo
Copy link
Contributor

mendozagioo commented Jan 8, 2020

This avoid the no close of modal with options:

$('#my-modal').modal({
backdrop: 'static',
keyboard: true
})

fix issue: #29978

Preview: https://deploy-preview-29986--twbs-bootstrap.netlify.com/docs/4.3/components/modal/#static-backdrop

@mendozagioo mendozagioo requested a review from twbs/js-review as a code owner Jan 8, 2020
@Johann-S Johann-S added this to Inbox in v5 via automation Jan 9, 2020
@Johann-S Johann-S added this to Inbox in v4.4.2 via automation Jan 9, 2020
v5 automation moved this from Inbox to Approved Jan 9, 2020
Copy link
Member

Johann-S left a comment

Nice PR thanks @mendozagioo 👍

Copy link
Member

MartijnCuppens left a comment

Seems to work fine, thanks!

XhmikosR added 2 commits Jan 10, 2020
@XhmikosR

This comment has been minimized.

Copy link
Member

XhmikosR commented Jan 10, 2020

Thanks for the patch @mendozagioo!

@Johann-S this will need to be manually backported to my v4-dev-xmr branch when you have some time :)

@XhmikosR XhmikosR merged commit 954a0b1 into twbs:master Jan 10, 2020
6 checks passed
6 checks passed
Node 10
Details
Node 10
Details
Node 12
Details
Node 12
Details
LGTM analysis: JavaScript No new or fixed alerts
Details
deploy/netlify Deploy preview ready!
Details
v5 automation moved this from Approved to Shipped Jan 10, 2020
@XhmikosR XhmikosR moved this from Inbox to Needs manual backport in v4.4.2 Jan 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
v5
  
Shipped
v4.4.2
  
Needs manual backport
4 participants
You can’t perform that action at this time.