Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v5.0.2 regression: grid col-N now overrides col-breakpoint #34335

Closed
danielkauffman opened this issue Jun 23, 2021 · 1 comment · Fixed by #34612
Closed

v5.0.2 regression: grid col-N now overrides col-breakpoint #34335

danielkauffman opened this issue Jun 23, 2021 · 1 comment · Fixed by #34612
Labels

Comments

@danielkauffman
Copy link

danielkauffman commented Jun 23, 2021

Between v5.0.1 and v5.0.2, the col-breakpoint declarations were moved above the col-N declarations. This breaks automatic column sizing. For example, a class declaration of "col-6 col-md" now creates a column that is always six columns wide and the column width does not become automatic at the breakpoint. Previously, the column width was six columns at the small sizes, and became automatic at the breakpoint.

Here is the diff showing the change in the compiled CSS: 688bce4#diff-1e4f2454c1c043f0cf31f56b51ec891c6bc0ff1c88985b82c7f89c0d8f78c4ba

This might be a result of this commit, although my guess is based mainly on the title of the commit, which describes changing the declaration order for cols: f2b47e1#diff-41667d8b9901aa9fa52483b538bb9026c287f2c663d2fdc01acffa06888cc087

@Qonstrukt
Copy link

Qonstrukt commented Jun 29, 2021

This breaks quite some of our layouts actually over a minor upgrade, I do hope you reconsider moving this to a hot fix instead of 5.1.0. It even breaks documentation examples as can be seen above my comment. 🙂

@XhmikosR XhmikosR changed the title Reversion from v5.0.1 to v5.0.2 where grid col-N now overrides col-breakpoint v5.0.2 regression: grid col-N now overrides col-breakpoint Jul 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants