Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vertical alignment of popovers #35453

Closed
3 tasks done
julien-deramond opened this issue Dec 2, 2021 · 2 comments · Fixed by #35527
Closed
3 tasks done

Vertical alignment of popovers #35453

julien-deramond opened this issue Dec 2, 2021 · 2 comments · Fixed by #35527

Comments

@julien-deramond
Copy link
Member

Prerequisites

Describe the issue

There is an issue in the main branch about popovers vertical alignment; they are slightly too low.
I would say it happens since fa33e83. There were other issues regarding this topic at the same moment so I'm not 100% sure.

Reference: https://getbootstrap.com/docs/5.1/components/popovers/#example

Screenshot from 2021-12-02 09-41-42

main branch rendering:

Screenshot from 2021-12-02 09-44-19

Additional note: if you switch browser tabs or scroll until they are hidden and scroll back until they are visible, the issue is fixed. So the issue seems to appear only at the init phase and is fixed after that the popovers are redrawn.

Reduced test cases

This issue is visible in the main branch.

What operating system(s) are you seeing the problem on?

Linux

What browser(s) are you seeing the problem on?

Chrome, Firefox

What version of Bootstrap are you using?

v5.2.0 (current main branch)

@XhmikosR
Copy link
Member

XhmikosR commented Dec 2, 2021

I would say it happens since fa33e83. There were other issues regarding this topic at the same moment so I'm not 100% sure.

This is impossible to have caused the issue 🙂

@GeoSot will identify the issue, but if you beat us to it, let us know.

@julien-deramond
Copy link
Member Author

julien-deramond commented Dec 2, 2021

This is impossible to have caused the issue slightly_smiling_face

I didn't understand your answer at first but yeah of course I copy pasted the wrong commit 😇. I thought it was the next one 94a596f.
Actually if you checkout 374eeec and replace SELECTOR_TOOLTIP_ARROW with .${this.constructor.NAME}-arrow in tooltip.js: it is well-aligned. If you do the same with 6f077ff: you'll see the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants