Popover/Tooltip: Fix vertical alignment on arrow of tip elements #35527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@julien-deramond you may check the 'fix' here. If you have any other more valid suggestion, I would like to hear it 😃 |
I tried other approaches the other day without succeeding. IMO it only happens at the "init" phase. Your fix corresponds to that so I haven't any other more valid suggestion 😃 Thanks for the fix @GeoSot! |
XhmikosR
changed the title
XhmikosR
changed the title
XhmikosR
force-pushed
the
gs/achieve-vertical-alignment-on-popovers
branch
from
bf776c7
to
32d6615
Compare
XhmikosR
approved these changes
Dec 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regression of #32692
Fixes #35453