Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref: refactor getSelector not to be exported #37438

Merged
merged 2 commits into from Nov 7, 2022
Merged

ref: refactor getSelector not to be exported #37438

merged 2 commits into from Nov 7, 2022

Conversation

GeoSot
Copy link
Member

@GeoSot GeoSot commented Nov 7, 2022 •
edited

Description

Just a minor refactor in the scope of Selector-engine. Method getSelector doesn't need to be exported as it is used localy

Type of changes

  • Refactoring (non-breaking change)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

julien-deramond
julien-deramond approved these changes Nov 7, 2022
View reviewed changes
Copy link
Member

@julien-deramond julien-deramond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just had a comment/question that can be treated without a need to re-ask for a review.

js/src/dom/selector-engine.js Show resolved Hide resolved
@GeoSot GeoSot marked this pull request as ready for review November 7, 2022 12:54
@GeoSot GeoSot requested a review from a team as a code owner November 7, 2022 12:54
@GeoSot GeoSot merged commit fcdfee9 into main Nov 7, 2022
@GeoSot GeoSot deleted the gs/ref-get-selector branch November 7, 2022 12:55
@XhmikosR XhmikosR mentioned this pull request Nov 11, 2022
Merged
@XhmikosR
Copy link
Member

This broke BrowserStack tests even more: https://github.com/twbs/bootstrap/actions/runs/3410515034/jobs/5673563662

@GeoSot
Copy link
Member Author

GeoSot commented Nov 11, 2022

Wasn't this but as it is being said, we have to resolve asap the BrowserStack problem or to check of any alternatives

@louismaximepiton louismaximepiton mentioned this pull request Aug 1, 2023
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julien-deramond julien-deramond julien-deramond approved these changes

Assignees
No one assigned
Labels
js refactoring
Projects
No open projects
v5.3.0
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@GeoSot @XhmikosR @julien-deramond