Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump rollup from 2.79.1 to 3.2.5 #37463

Merged
merged 3 commits into from
Nov 11, 2022
Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Nov 9, 2022

Bumps rollup from 2.79.1 to 3.2.5.

Release notes

Sourced from rollup's releases.

v3.2.5

3.2.5

2022-11-01

Bug Fixes

  • We deconflicting classes, ensure the original class name still does not shadow variables (#4697)

Pull Requests

v3.2.4

3.2.4

2022-10-31

Bug Fixes

  • Always use forward slashes in chunk ids when preserving modules, even on Windows (#4693)
  • Escape problematic characters in ids when rewriting import.meta.url (#4693)

Pull Requests

v3.2.3

3.2.3

2022-10-18

Bug Fixes

  • Fix an issue whre Rollup confused new.target with import.meta (#4679)
  • Ensure that Rollup does not make assumptions about the value of unknown namespace import members (#4684)

Pull Requests

v3.2.2

3.2.2

2022-10-16

... (truncated)

Changelog

Sourced from rollup's changelog.

3.2.5

2022-11-01

Bug Fixes

  • We deconflicting classes, ensure the original class name still does not shadow variables (#4697)

Pull Requests

3.2.4

2022-10-31

Bug Fixes

  • Always use forward slashes in chunk ids when preserving modules, even on Windows (#4693)
  • Escape problematic characters in ids when rewriting import.meta.url (#4693)

Pull Requests

3.2.3

2022-10-18

Bug Fixes

  • Fix an issue whre Rollup confused new.target with import.meta (#4679)
  • Ensure that Rollup does not make assumptions about the value of unknown namespace import members (#4684)

Pull Requests

3.2.2

2022-10-16

Bug Fixes

  • Do not hang/crash on hashbang comments in input modules (#4676)

... (truncated)

Commits

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [rollup](https://github.com/rollup/rollup) from 2.79.1 to 3.2.5.
- [Release notes](https://github.com/rollup/rollup/releases)
- [Changelog](https://github.com/rollup/rollup/blob/master/CHANGELOG.md)
- [Commits](rollup/rollup@v2.79.1...v3.2.5)

---
updated-dependencies:
- dependency-name: rollup
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@XhmikosR
Copy link
Member

XhmikosR commented Nov 9, 2022

@GeoSot note that this breaks our license, it becomes Bootstrap [object Object] v5.2.2 (https://getbootstrap.com/). Not sure about other breaking changes, this is the one I noticed.

If you have any fixes, feel free to push them to this branch :)

@GeoSot GeoSot requested a review from a team as a code owner November 9, 2022 09:37
@GeoSot
Copy link
Member

GeoSot commented Nov 9, 2022

@XhmikosR Is fine now. Seems ok now (on 3.0 banner started to pass some information inside the banner hoook)

https://github.com/rollup/rollup/releases

Functions passed to output.banner/footer/intro/outro are now called per-chunk with some chunk information (rollup/rollup#4543)

@XhmikosR
Copy link
Member

Nice, thanks!

Did you notice any other issues yourself? It's a major version, so you know.

@GeoSot
Copy link
Member

GeoSot commented Nov 10, 2022

As far as I 've noticed, only smaller spaces, and the difference below (at udm), that doesn't seem crusial

image

However, maybe is a good idea, to have an action that will compare dist files, on every Dependabot branch, or on package.lock change.

@XhmikosR
Copy link
Member

BTW it seems the BrowserStack tests failing is valid. They broke somewhere before, probably #37438

@XhmikosR XhmikosR merged commit 634e449 into main Nov 11, 2022
@XhmikosR XhmikosR deleted the dependabot/npm_and_yarn/rollup-3.2.5 branch November 11, 2022 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants