-
-
Notifications
You must be signed in to change notification settings - Fork 78.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Collapse: Fix multiple id
s calls
#38989
Conversation
As for the tests, yeah, ideally we should have one, because apparently it's not covered by the existent tests :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
its an clear review in this program
I had checked the program in this compailer in this program and i have check the program in VS Code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice analysis 💪 LGTM!
id
s calls
* fix: regression of #38989 * Add unit test in selector-engine.spec.js --------- Co-authored-by: Julien Déramond <juderamond@gmail.com> Co-authored-by: XhmikosR <xhmikosr@gmail.com>
Description
With
git bisect
, it seems the breaking change appeared from #37438.The only change in here was that the
parseSelector
was applied in any case and not on some specific cases anymore. Reverting this change.Motivation & Context
Break some (wrong?) use cases.
Type of changes
Checklist
npm run lint
)Live previews
Tried it with the minimal code:
Related issues
Closes #38974.