Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typeahead Keyboard Nav #5806

Closed
ecmel opened this issue Nov 6, 2012 · 5 comments
Closed

Typeahead Keyboard Nav #5806

ecmel opened this issue Nov 6, 2012 · 5 comments
Labels

Comments

@ecmel
Copy link

ecmel commented Nov 6, 2012

Keyboard up/down key selects every other item if there are more than 2 suggestions in Firefox 16.0.2 and 2.2.2-wip

pmclanahan pushed a commit to pmclanahan/bootstrap that referenced this issue Nov 13, 2012
@bond-
Copy link

bond- commented Nov 15, 2012

This is noticeable and a irritating bug. Please try to merge it in the next release.

@peterbe
Copy link

peterbe commented Nov 26, 2012

@pmclanahan do you think this solution is better or worse?
#5706

I see you have unit tests in this. Have you submitted a pull request?

@pmclanahan
Copy link

@peterbe Yeah. I submitted #5862 a while ago. No movement on it so far though.

Either solution works. Using the !! instead of removing the ! just converts it to a boolean type instead of using the return value of the ~ operator in boolean context. Because it's an extra conversion and thus superfluous I didn't do that. If it seems clearer to use the !! then it works perfectly well. I do think that my tests updates are a very important part of the patch however.

@collimarco
Copy link

+1 With Firefox 16.0.2 and Bootstrap 2.2.1 I get this behavior:

  • two suggestions: arrow keys don't work
  • more than two suggestions: two-items step... selection skips the item in the middle

@mdo
Copy link
Member

mdo commented Nov 28, 2012

Dupe of #5706.

@mdo mdo closed this as completed Nov 28, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants