Fix issue with double move event firing in typeahead. #5862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You should rebase your branch against master in order to get rid of this commit history |
|
Oh wow. What changed? It was clean when I pushed. |
Fix test to catch issue. Fix twbs#5806.
|
Fixed. Thanks for the heads-up @Ninir. |
Closed
|
Issue I mentioned is closed as a dupe of this one. This one fixes #5706 too. |
fat
added a commit
that referenced
this pull request
Dec 7, 2012
…d-nav Fix issue with double move event firing in typeahead.
|
cool, thanks guys! Also ❤️ for the tests! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test for keyboard nav with the arrow keys only fired
the keyup event. The issue was with the mechanism that
prevented double
movemethod firing for keyup, keydown,and keypress.
This adds a more complete triggering of a full key press
and fixes the issue with the double calls to
move.