Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sidebar rows affect rows in the middle. #661

Closed
surajreddy opened this issue Nov 18, 2011 · 8 comments
Closed

Sidebar rows affect rows in the middle. #661

surajreddy opened this issue Nov 18, 2011 · 8 comments
Milestone

Comments

@surajreddy
Copy link

I'm having issue 516, even after upgrading to the newest css. #516

Since the previous issue is not getting any attention, and I can't reopen it, I'm opening a new issue.

Here is a picture illustrating the issue, to make it clearer - https://skitch.com/surajreddy/gjasc/unstash-a-platform-for-collaborative-consumption

It seems like the "row" div on the left is taking up the entire horizontal space.

We've been trying to fix this problem for weeks, and would greatly appreciate a fix.

Thanks!

@mdo
Copy link
Member

mdo commented Nov 20, 2011

Are you using version 1.4?

@surajreddy
Copy link
Author

Yes, I updated bootstrap.css to ensure that.

@surajreddy
Copy link
Author

This is what @d3chapma said - I'll be testing it out in 24 hours as I'm currently away:

So, I was able to getting it looking reasonable in my browser. Here is the css I used.

div.row {
float: left;
padding-bottom: 10px;
width: 100%;
}

div.span10 {
width: 560px;
}

the change in width to span10 could and should be solved by using span9 instead.

@surajreddy
Copy link
Author

The css above fixes this issue.

Can someone look into it and merge it into the bootstrap code properly? I've just added it to the bottom of our bootstrap.css

Thanks.

@jubianchi
Copy link

@surajreddy thanks for your work! I did not have time to check your fix. I'll try it as soon as possible!

@surajreddy
Copy link
Author

@jubianchi thanks.

timcheadle added a commit to timcheadle/bootstrap that referenced this issue Nov 22, 2011
@mdo
Copy link
Member

mdo commented Jan 7, 2012

Just closed #678 to fix the floats problem in 2.0-wip. You might be having another issue that's different from that—if so, please open a new issue with a code snippet and more details.

@mdo mdo closed this as completed Jan 7, 2012
@surajreddy
Copy link
Author

Thanks @markdotto

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants