Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Add WAI-ARIA roles to examples/theme/index.html (document, main) #12228

Closed
wants to merge 1 commit into from

Conversation

westurner
Copy link
Contributor

@cvrebert
Copy link
Collaborator

IMHO, the HTML comment seems unnecessary. We don't call out our use of ARIA much elsewhere.

@westurner
Copy link
Contributor Author

Your call. As a newcomer reading the source (or documentation) it's not immediately clear that while WAI-ARIA markup is extremely helpful, it's not necessary for Bootstrap to function (though it is much easier to understand and build accessibility support in from the start).

Clarification regarding the effect of role='document' / role='application' on keyboard shortcuts may also be helpful, if in scope for this project.

Thanks for your time!

@mdo
Copy link
Member

mdo commented Jan 18, 2014

Yeah we don't need the comment. The roles will do just fine though. If you want to call more attention to the ARIA roles, go ahead and submit a PR for the accessibility section of our docs.

@westurner
Copy link
Contributor Author

Yeah we don't need the comment.

Done.

If you want to call more attention to the ARIA roles, go ahead and submit a PR for the accessibility section of our docs.

http://getbootstrap.com/getting-started/#accessibility

A11Y and MDN Accessibility are both great links.

"site:getbootstrap.com+ARIA" shows markup and a blog post which references #9186

There aren't any direct links to specs. Keyword references to 508 and WCAG may also be helpful.

A Deep link into the MDN ARIA page may be helpful:

@westurner
Copy link
Contributor Author

Clarification regarding the effect of role='document' / role='application' on keyboard shortcuts may also be helpful, if in scope for this project.

http://a11yproject.com/posts/how-to-use-application-role/

@cvrebert
Copy link
Collaborator

Merged as a73dacf.

@cvrebert cvrebert closed this Jan 19, 2014
@westurner westurner deleted the aria branch January 19, 2014 17:49
@westurner westurner changed the title Added WAI-ARIA roles to examples/theme/index.html (document, main) ENH: Add WAI-ARIA roles to examples/theme/index.html (document, main) Aug 20, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants