Darken @gray-light to meet accessibility guidelines #13854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I didn't see a section in the guidelines about whether pull requests should include compiled code. I can amend the commit to add compiled CSS if that's what you guys prefer. |
`@gray-light` darkens from #999 to #777, which puts `.text-muted` at the threshold for the 4.5:1 WCAG minimum contrast[1]. #777:#fff is 4.48:1. The “Example” headers in docs become #959595, which is contrast ratio 3:1, the minimum for larger text. Since the headers are less important than the surrounding text, 3:1 is fine and an improvement on the previous #bbb:#fff (1.92:1). Fixes issue #13847. [1] http://www.w3.org/TR/UNDERSTANDING-WCAG20/visual-audio-contrast-contrast.html
|
@ssorallen No need, we'll tackle the compilation. Less changes for merge conflicts :). |
mdo
added a commit
that referenced
this pull request
Jun 18, 2014
Darken @Gray-Light to meet accessibility guidelines
This was referenced Jun 18, 2014
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@gray-lightdarkens from#999to#777, which puts.text-mutedat thethreshold for the 4.5:1 WCAG minimum contrast[1].
#777:#fffis 4.48:1.The “Example” headers in docs becomes #959595, which is contrast ratio
3:1, the minimum for larger text. Since the headers are less important
than the surrounding text, 3:1 is fine and an improvement on the
previous
#bbb:#fff(1.92:1).Fixes issue #13847.
[1] http://www.w3.org/TR/UNDERSTANDING-WCAG20/visual-audio-contrast-contrast.html