Update grunt-csscomb

[XhmikosR]

This is a WIP until csscomb has the remaining issues sorted on their side, thus the output CSS should be the same then.

For reference csscomb/csscomb.js#232

[XhmikosR]

@tonyganch: you can see here the changes in comments.

[mdo]

What's the status on this? Can't say I'm enthusiastic about moving inline comments to the next line. Also, tons of this conflicts with what I'm working on for v4, so maybe we just punt it until that kicks off publicly?

[tonyganch]

I've fixed behaviour of comments.
I've also cloned this branch and run grunt with new CSScomb to see the new diff:
tonyganch/bootstrap@8d348ed
I'm not sure why .map files are modified, maybe I do something differently.
But you can see that your inline comments are safe now.

There is also one line I can do nothing about:
tonyganch/bootstrap@8d348ed#diff-4e5779e4dffa63415fd5bda19e74ff90L103
The diff is caused by space-after-opening-brace: "\n" and I'm pretty sure that's a correct way for this option to work.

There will be no more beta releases of CSScomb, so these "comment" changes will be published some time later with a stable release.

[XhmikosR]

I think that looks good @tonyganch, thanks!

I will wait for a new npm package and then I'll update the PR and merge.

[XhmikosR]

BTW the map files change must be because of clean-css version difference but nothing to worry about.

[cvrebert]

We should check whether the new CSSComb v3.0.0 addresses our problem.

[XhmikosR]

csscomb/csscomb.js#232 (comment)

[tonyganch]

Let me know if the problem remains, please

[XhmikosR]

@tonyganch: the npm package seems the same (3.0.0-1). Did you forget to publish a new one?

EDIT: nvm, I confused the grunt package with csscomb itself 👊

[tonyganch]

@XhmikosR, Version 3.0.0 last updated 13 minutes ago

-> % npm i csscomb
csscomb@3.0.0 ../node_modules/csscomb
├── commander@2.0.0
├── vow@0.4.4
└── csscomb-core@2.0.1 (minimatch@0.2.12, vow-fs@0.3.2)

[XhmikosR]

Yeah, see my edit above :/

Everything looks good now, I'll merge it when I'm back home since I don't want to do things in a hurry :)

[tonyganch]

This line should be replaced with "space-between-declarations": "\n"