Only close modal if escape was hit with keydown; fixes #13929 #14000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I can confirm that this seems to fix the Esc-after-opening-the-print-dialog and Esc-with-an-open- |
|
Ah, yeah, testcase here: http://jsbin.com/feloj/2/edit |
|
BTW, in #13853 I'll refactor most of the async unit tests to look like the two I added here, because then they actually fail instead of just timing out. |
|
oh wow that's super weird |
|
thanks for the fix w/tests 😍 |
fat
added a commit
that referenced
this pull request
Jul 6, 2014
Only close modal if escape was hit with keydown; fixes #13929
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #13929 and also #13855.
Adds two unit tests for this as well.
/cc @fat