Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update jspm configuration #16101

Merged
merged 1 commit into from
Mar 19, 2015
Merged

Update jspm configuration #16101

merged 1 commit into from
Mar 19, 2015

Conversation

guybedford
Copy link
Contributor

This updates to the latest jspm configuration options.

The files property is necessary to override the files property in the base package.json which caused the CSS folder to be ignored.

@cvrebert
Copy link
Collaborator

The base files already contains dist (of which css is a subdirectory), so I'm unclear why a jspm override is necessary. Plus, there's no top-level css directory in Bootstrap, so the override also seems wrong to me in that respect.
Or am I missing something?

@lookfirst
Copy link
Contributor

@cvrebert In the distribution there is a top level css folder. For example, if you download this file, you will see that there is a css folder in there.

Due to this misconfiguration, if you install bootstrap using jspm, the folder is empty.

@cvrebert cvrebert added this to the v3.3.5 milestone Mar 19, 2015
@cvrebert
Copy link
Collaborator

Ah. Okay, gotcha.

cvrebert added a commit that referenced this pull request Mar 19, 2015
@cvrebert cvrebert merged commit cb4144a into twbs:master Mar 19, 2015
@cvrebert cvrebert mentioned this pull request Mar 19, 2015
@lookfirst
Copy link
Contributor

👍 thanks!

@guybedford
Copy link
Contributor Author

Amazing, thank you.

@jczerwinski
Copy link

I would like to be able to consume the less source as a dependency via JSPM, rather than only the compiled CSS. Restricting the JSPM config to the dist directory prevents this. Could we expand the config to include the less source?

@lookfirst
Copy link
Contributor

@jczerwinski That issue #12906 seems to be closed. Honestly, I'm kind of siding with the BS developers right now because importing the .less files individually would be very difficult as you would need to know the dependencies between them. For example, wells.less depends on variables.less and who knows what in the future. It would be very brittle over time to have that sort of dependency chain. You might as well just point at the compiled CSS.

@cvrebert
Copy link
Collaborator

@lookfirst It's somewhat more due to a jspm-side limitation, AIUI: #16118.

@lookfirst
Copy link
Contributor

@cvrebert Thanks! It just sounds like a recipe for disaster. =(

@jczerwinski
Copy link

Yeah, makes sense. I've moved on. Thanks!
On Mar 24, 2015 13:01, "Jon Stevens" notifications@github.com wrote:

@cvrebert https://github.com/cvrebert Thanks! It just sounds like a
recipe for disaster. =(


Reply to this email directly or view it on GitHub
#16101 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants