Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SCSS-Lint dependency #20250

Merged
merged 1 commit into from
Jul 8, 2016

Conversation

tagliala
Copy link
Contributor

@tagliala tagliala commented Jul 6, 2016

SCSS-Lint 0.49.0 modifies Shorthand linter to report lint if a shorthand
of a length not specified in the allowed_shorthands option is used.

New defaults include "4" in the list of allowed shorthands, so we are changing our configuration accordingly.

Ref: sds/scss-lint@e283d16

SCSS-Lint 0.49.0 modifies Shorthand linter to report lint if a shorthand
of a length not specified in the allowed_shorthands option is used.

New defaults include "4" in the list of allowed shorthands, so we are changing our configuration accordingly.

Ref: sds/scss-lint@e283d16
@tagliala tagliala force-pushed the update-scss_lint-dependency branch from 34a5f6e to 6eecea6 Compare July 6, 2016 14:38
@tagliala
Copy link
Contributor Author

tagliala commented Jul 6, 2016

Note that SCSS-Lint 0.49.0 will find some lints when used with the old configuration:

$ grunt scsslint
Running "scsslint:core" (scsslint) task
Running scss-lint on core
scss/_custom-forms.scss:145:12 [W] Shorthand: Shorthands of length `4` are not allowed. Value was `$custom-select-padding-y $custom-select-padding-x + $custom-select-indicator-padding $custom-select-padding-y $custom-select-padding-x`
scss/_tooltip.scss:38:21 [W] Shorthand: Shorthands of length `4` are not allowed. Value was `$tooltip-arrow-width $tooltip-arrow-width $tooltip-arrow-width 0`
scss/_tooltip.scss:64:21 [W] Shorthand: Shorthands of length `4` are not allowed. Value was `$tooltip-arrow-width 0 $tooltip-arrow-width $tooltip-arrow-width`

@cvrebert
Copy link
Collaborator

cvrebert commented Jul 6, 2016

X-Ref: stylelint/stylelint#1402

cvrebert referenced this pull request Jul 8, 2016
[skip sauce]
@cvrebert cvrebert added this to the v4.0.0-alpha.3 milestone Jul 8, 2016
@cvrebert cvrebert merged commit 1347cb0 into twbs:v4-dev Jul 8, 2016
@cvrebert
Copy link
Collaborator

cvrebert commented Jul 8, 2016

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants