Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dropdown example in docs (Fix #20410) #20434

Merged
merged 2 commits into from
Aug 4, 2016
Merged

Fix dropdown example in docs (Fix #20410) #20434

merged 2 commits into from
Aug 4, 2016

Conversation

pvdlg
Copy link
Contributor

@pvdlg pvdlg commented Aug 2, 2016

Fix #20410

@judetucker
Copy link

This is a dupe of #20411

@pvdlg pvdlg mentioned this pull request Aug 2, 2016
Closed
@pvdlg
Copy link
Contributor Author

pvdlg commented Aug 2, 2016

Indeed, I should have search more.
Although I also removed the part of the doc that recommend to use data-target for links as it seems it's irrelevant in Bootstrap v4 (The JS find the parent .dropdown element without requiring a data-target or an href).

@mdo mdo added this to the v4.0.0-alpha.3.1 milestone Aug 4, 2016
@mdo mdo merged commit 0416f76 into twbs:v4-dev Aug 4, 2016
@judetucker judetucker mentioned this pull request Aug 4, 2016
Closed
@pvdlg pvdlg deleted the fix-20410 branch December 29, 2016 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
docs js
Projects
None yet
Milestone
v4.0.0-alpha.4
Development

Successfully merging this pull request may close these issues.
3 participants
@pvdlg @judetucker @mdo