Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename .tag to .badge to avoid conflicting with WordPress #21020

Merged
merged 1 commit into from
Oct 27, 2016

Conversation

mdo
Copy link
Member

@mdo mdo commented Oct 27, 2016

Fixes #20542.

This renames the .tag component to .badge to avoid conflicts with some core WordPress styling. It's a bit of a flip flop, but that's okay. It's an easy fix on our end to resolve this larger issue with a huge community. I've updated the file names, docs pages, examples, mixins, Sass variables, and more. Should be good to go.

@mdo mdo added this to the v4.0.0-alpha.6 milestone Oct 27, 2016
@mdo mdo merged commit bcbbc8e into v4-dev Oct 27, 2016
@mdo mdo deleted the rename-tag-to-badge branch October 27, 2016 02:53
@mdo mdo mentioned this pull request Oct 27, 2016
@browner12
Copy link
Contributor

omg, you've got to be kidding me

@guylepage3
Copy link

@mdo, .badge sounds good to me. i don't think there are any conflicts with anything else.

@j0an
Copy link

j0an commented Nov 14, 2016

:'(

so we need an update on http://v4-alpha.getbootstrap.com/components/tag/ right?

@guylepage3
Copy link

@j0an yes.

@mdo
Copy link
Member Author

mdo commented Nov 14, 2016

Hosted docs will get updated when we do a release. Until then, they reflect the latest release. Docs in the branch are up to date though.

It's worth noting this is how all our releases go; docs updates come with the general release.

@guylepage3
Copy link

thanks for letting us know the doc release process @mdo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants