Adds a border radius to modal headers #23799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XhmikosR
approved these changes
Sep 13, 2017
mdo
requested changes
Oct 2, 2017
andresgalante
force-pushed
the
modal-header-color
branch
from
09111d7
to
7608707
Compare
|
@mdo I am sorry I had an auto formatter on. 😞 I fixed the PR but it's still showing a strange diff, I don't know why. |
mdo
approved these changes
Oct 3, 2017
Closed
|
@andresgalante @mdo |
tmorehouse
added a commit
to bootstrap-vue/bootstrap-vue
that referenced
this pull request
Dec 6, 2017
…plied The original bug (twbs/bootstrap#23798) was fixed in Bootstrap V4.beta.2: twbs/bootstrap#23799
|
@andresgalante Actually a similar bug persists when using a background on modal-footer (it protrudes from the bottom rounded corners) |
tmorehouse
added a commit
to bootstrap-vue/bootstrap-vue
that referenced
this pull request
Dec 6, 2017
…plied (#1433) The original bug (twbs/bootstrap#23798) was fixed in Bootstrap V4.beta.2: twbs/bootstrap#23799
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #23798
When a background color is added to the modal header it shows a square corner. This PR is adding border radius to it so it follows the border radius.
Should I add a section on modal documentation about styling it? How to change the color of the border, text and background with utility classes like we do on cards
What do you think?