Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor Sass cleanup and consistency changes. #23959

Merged
merged 1 commit into from Sep 17, 2017
Merged

Minor Sass cleanup and consistency changes. #23959

merged 1 commit into from Sep 17, 2017

Conversation

XhmikosR
Copy link
Member

Just picked up some of the fixes I found from my stylelint PR

mdo
mdo approved these changes Sep 17, 2017
View reviewed changes
Copy link
Member

@mdo mdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Normally I keep the same values of multiple properties aligned for easy multi-line editing, but I'm not super attached to it.

@XhmikosR XhmikosR merged commit 5cec8e0 into v4-dev Sep 17, 2017
@XhmikosR XhmikosR deleted the v4-dev-xmr-sass-cleanup branch September 17, 2017 05:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdo mdo mdo approved these changes

@bardiharborow bardiharborow bardiharborow approved these changes

@Johann-S Johann-S Awaiting requested review from Johann-S

Assignees
No one assigned
Labels
css v4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@XhmikosR @mdo @bardiharborow