Reduce whitespace liquid outputs. #24470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XhmikosR
force-pushed
the
v4-dev-xmr-reduce-liquid-whitespace
branch
from
840d794
to
b909138
Compare
|
@mdo: I added one more patch which fixes the pages' description. Previously the generic site's description was being used. |
XhmikosR
force-pushed
the
v4-dev-xmr-reduce-liquid-whitespace
branch
from
b909138
to
83e3dc6
Compare
XhmikosR
changed the title
XhmikosR
commented
Oct 20, 2017
_includes/social.html
Outdated
| <meta property="og:title" content="{{ site.title }}"> | ||
| <meta property="og:description" content="{{ site.description }}"> | ||
| {% endif %} | ||
| <meta property="og:url" content="{% if page.title %}{{ site.url }}{{ page.url }}{% else %}{{ site.url | append: "/" }}{% endif %}"> |
There was a problem hiding this comment.
This might be possible to simplify more by just using {{ site.url }}{{ page.url }} since for the index page
XhmikosR
force-pushed
the
v4-dev-xmr-reduce-liquid-whitespace
branch
2 times, most recently
from
72e6565
to
0eeae14
Compare
XhmikosR
changed the title
mdo
approved these changes
Oct 22, 2017
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mdo: alternatively we can remove the whole comment block.