New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce whitespace liquid outputs. #24470

Merged
merged 2 commits into from Oct 22, 2017

Conversation

Projects
2 participants
@XhmikosR
Member

XhmikosR commented Oct 20, 2017

@mdo: alternatively we can remove the whole comment block.

@XhmikosR XhmikosR added docs v4 labels Oct 20, 2017

@XhmikosR XhmikosR requested a review from mdo Oct 20, 2017

@XhmikosR

This comment has been minimized.

Show comment
Hide comment
@XhmikosR

XhmikosR Oct 20, 2017

Member

@mdo: I added one more patch which fixes the pages' description. Previously the generic site's description was being used.

Member

XhmikosR commented Oct 20, 2017

@mdo: I added one more patch which fixes the pages' description. Previously the generic site's description was being used.

@XhmikosR XhmikosR changed the title from Reduce whitespace liquid outputs. to Reduce whitespace liquid outputs and simplify social.html. Oct 20, 2017

Show outdated Hide outdated _includes/social.html Outdated

@XhmikosR XhmikosR changed the title from Reduce whitespace liquid outputs and simplify social.html. to Reduce whitespace liquid outputs. Oct 21, 2017

@mdo

mdo approved these changes Oct 22, 2017

@XhmikosR XhmikosR merged commit fbd42af into v4-dev Oct 22, 2017

4 checks passed

bundlesize Good job! bundle size < maxSize
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
hound No violations found. Woof!

@XhmikosR XhmikosR deleted the v4-dev-xmr-reduce-liquid-whitespace branch Oct 22, 2017

@mdo mdo referenced this pull request Oct 22, 2017

Closed

Beta 3 ship list #24439

@mdo mdo added this to Shipped in v4 Beta 3 Oct 22, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment