-
-
Notifications
You must be signed in to change notification settings - Fork 78.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix branch for coveralls badge #26561
Conversation
@Johann-S: can you change it to shields.io? |
Pull Request Test Coverage Report for Build 27201
💛 - Coveralls |
1 similar comment
Pull Request Test Coverage Report for Build 27201
💛 - Coveralls |
Wow we should just run coverall for one build not for all 😆 and done @XhmikosR 😉 |
I'm gonna change the settings to stop Coveralls from commenting. |
Not sure if it's the solution, because it's interesting to know if a PR decrease or increase our Coverage 😟 |
@Johann-S: how about we move the coveralls command from the npm scripts to travis only? |
The diff shows @Johann-S. We just won't get spammed by it. |
Yep sure, if it's allow us to run it just once it would be perfect ! 👍 |
Oh yes you're right, I wasn't sure about that 😄 |
@Johann-S: not sure why, but every time you change the package-lock.json you make many changes. Please make sure you are using |
I use npm |
Yeah, please move to 8 or 10. |
OK, so this runs coveralls after success, but for both builds. It doesn't seem to affect anything. |
and no more comments 🎆 |
I could move the |
Much better to just run it once 👍 |
d64289c
to
98f8980
Compare
Or you can revert that change and let |
98f8980
to
728c30b
Compare
OK, I think we just need a little shell help. See my last push. |
728c30b
to
3e0dfb1
Compare
I made a change, which run |
Does the job indeed! But I think we should not export another variable and just do the version check in the if check. Something like this: https://stackoverflow.com/questions/48250235/how-to-setup-travis-to-skip-script-on-particular-nodejs-version |
What do you think about that : - if [[ `node -v` = 8* ]]; then npm run coveralls; fi Finally I doesn't work... 😢 |
0ace573
to
93e40e8
Compare
LGTM @Johann-S, feel free to rebase and merge :) |
@Johann-S: I just become aware there's a |
19fc9d3
to
9e9ed0c
Compare
OK, it works :) I'm gonna merge when the build finishes. |
9e9ed0c
to
67d83a3
Compare
/CC @XhmikosR