Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default boundary value to window #26842

Closed
wants to merge 1 commit into from
Closed

Change default boundary value to window #26842

wants to merge 1 commit into from

Conversation

simPod
Copy link
Contributor

@simPod simPod commented Jul 10, 2018

Trying to address these
#25428
floating-ui/floating-ui#535
#26836

@simPod
Copy link
Contributor Author

simPod commented Jul 10, 2018

Needs fixing tests, but not sure if it's viable. It's BC break

@Johann-S
Copy link
Member

The default value is scrollParent because it's the default value specified by Popper.js so we won't change that, unless Popper.js change their default value.

You have the hability to change this value, so there are no need to change that

@Johann-S Johann-S closed this Jul 10, 2018
@simPod
Copy link
Contributor Author

simPod commented Jul 10, 2018

Only the thing that it is the bug 🐛

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants