Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix custom select caret issue on IE #28112

Merged
merged 3 commits into from Jan 25, 2019
Merged

Fix custom select caret issue on IE #28112

merged 3 commits into from Jan 25, 2019

Conversation

ysds
Copy link
Member

@ysds ysds commented Jan 24, 2019 •
edited

If you add a width to a custom select, the display differs between IE and other browsers.

image

Demo: https://jsbin.com/xihojulawa/1/edit?output

This PR fix that.

@ysds ysds requested a review from a team as a code owner January 24, 2019 02:25
MartijnCuppens
MartijnCuppens approved these changes Jan 24, 2019
View reviewed changes
Copy link
Member

@MartijnCuppens MartijnCuppens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@MartijnCuppens MartijnCuppens added this to Inbox in v4.3 via automation Jan 24, 2019
@MartijnCuppens MartijnCuppens merged commit e65dccf into twbs:v4-dev Jan 25, 2019
v4.3 automation moved this from Inbox to Shipped Jan 25, 2019
@mdo mdo mentioned this pull request Jan 25, 2019
Closed
@ysds ysds deleted the patch-2 branch February 16, 2019 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MartijnCuppens MartijnCuppens MartijnCuppens approved these changes

Assignees
No one assigned
Labels
css v4
Projects
No open projects
v4.3
  
Shipped
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ysds @MartijnCuppens