New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Utilities/helpers split & utilities API #28445
Conversation
For viewport utilities, I'm thinking |
So here's a baseline version of what I'm thinking about—one giant Sass map for all https://www.sassmeister.com/gist/efa2593de91ddcc60808c44fe1ea9301 Thoughts? |
I guess you're talking about the Or am I missing something here? |
Oh! Damn, yes I am! I was completely off base, apologies! |
@MartijnCuppens: something isn't right with this branch. You are removing files you are not supposed to touch here. |
b1a7b1a
to
e9054f6
Compare
@XhmikosR, fixed it. @mdo, I simplified the This is still a work in progress, I'm personally going to give this PR more priority to avoid the situations like th Hugo branch where we needed to rebase it every so often. |
@MartijnCuppens Thoughts on ditching the |
I've opened #28506 to track this, that's a decision we can make independent from this, but I think it's a good idea. This will make it possible to ditsh this part here and simplify the map-gets you mentioned before: bootstrap/scss/_utilities.scss Lines 50 to 53 in a41ab9d
|
11db464
to
c5a0434
Compare
c5a0434
to
09ede1e
Compare
3b8d66d
to
25918f6
Compare
25918f6
to
840526b
Compare
840526b
to
fff0f2d
Compare
fff0f2d
to
d7c0271
Compare
d7c0271
to
9dd51ee
Compare
Ping @twbs/css-review for review |
9dd51ee
to
82f6f29
Compare
FYI: the diff between classes: https://www.diffchecker.com/noUio3fe. Only some responsive |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's do this!
Fixes #28367
Split up helpers/utilities and utilities API for extending or getting more control over the generated utilities.
Features
map-get-multiple()
function to get multiple keys from a mapNotes
New documentation about the utility API:
https://deploy-preview-28445--twbs-bootstrap.netlify.com/docs/4.3/utilities/api/