Move close icon to components in docs#28512
Merged
MartijnCuppens merged 2 commits intomasterfrom May 10, 2019
Merged
Conversation
Member
|
Should we backport this? |
Member
Author
|
Nah, it's just the place where it's documented, not that important but if we're going to use the #28445 for utilities, it would be better if we move this. |
Member
|
@mdo: your thoughts? |
Contributor
My only concern is: Line 2 in 06635be If remove this, the |
MartijnCuppens
force-pushed
the
master-mc-move-close-icon
branch
from
a111b8e to
f2d1ed2
Compare
Member
Author
|
|
Contributor
|
LGTM👍, but would be perfect by changing its name to "Close button" IMO 😄 |
ysds
approved these changes
May 10, 2019
Member
Author
|
It could also be a link in another context, so let's leave it for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The close icon is a component, not a utility.