Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix floating labels overlay with chrome auto fill #28635

Closed
wants to merge 2 commits into from

Conversation

e3duardo
Copy link

@e3duardo e3duardo commented Apr 9, 2019

I had this error with the example of floating labels today, and looking for some solutions I found the fix I'm committing.
I tested in latest chrome for latest mac, I do not know about other browsers, but I would like to help.

Captura de Tela 2019-04-09 às 20 34 50

@e3duardo e3duardo requested a review from a team as a code owner April 9, 2019 23:55
Copy link
Member

@MartijnCuppens MartijnCuppens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will invalidate the selector for non-webkit browsers, see https://deploy-preview-28635--twbs-bootstrap.netlify.com/docs/4.3/examples/floating-labels/ in for example Firefox to reproduce this issue.

@e3duardo
Copy link
Author

This will invalidate the selector for non-webkit browsers, see https://deploy-preview-28635--twbs-bootstrap.netlify.com/docs/4.3/examples/floating-labels/ in for example Firefox to reproduce this issue.

I saw it here, that bad! I really wanted this functionality in my project, even with fields filled in automatically, do you think this is only possible with javascript?

@XhmikosR
Copy link
Member

@MartijnCuppens if you think this is a no go let's close it.

@MartijnCuppens
Copy link
Member

Should be possible by splitting the selectors & duplicating the properties. @e3duardo, could you have a look at that?

@MartijnCuppens
Copy link
Member

Just tested this, this doesn't seem to be a problem in Chrome (not on mac or Windows). If this still is a problem please reopen and provide additional testing info.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants