set min-height for form-control textarea

[m5o]

• set min-height for .form-control textarea
  • prevent user from shrink textarea
  • set minimum height equals default input height

before	after

📷 Chrome 75 / Mac OS X 10.14.6

[ysds]

To fix also #28901, is it better add min-height to .form-control and remove the specific heights?

[MartijnCuppens]

@ysds, that would reintroduce #18842, unless #28917 is merged.

[ysds]

@m5o Would you add the min-height to .form-control and .form-select directory and remove the specific height from those? Also need to modify the sizing options and the combinations with .input-groups.

[m5o]

@ysds done, hopefully as you requested.

🤔 I don't know if, for consistency, it would make sense to set min-height also to .form-file

[ysds]

@m5o nice, LGTM 👍

[ysds]

.form-file use position: absolute, so would have to use height.

[MartijnCuppens]

Firefox add 2px to its select because of this bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1560824, so we should set height on selects unfortunately

[ysds]

umm, confirmed

[mdo]

@MartijnCuppens Can you re-review, please?

[XhmikosR]

Are we sure about backporting this BTW?

[MartijnCuppens]

#18842 still seemed to be an issue. I've pushed a working fix (219e1c68ce6405778bcaf865841cc89f3d80b7c6) and also committed a fix for the input groups.

[XhmikosR]

@MartijnCuppens: this doesn't apply clean on v4-dev-xmr. Can you backport it manually please?

[MartijnCuppens]

I'm afraid we can't backport this easily since .form-controls can be selects too in v4. To make this work we'll need to rewrite quite a lot and this might introduce breaking changes.