Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix date inputs heights in safari #30353

Merged
merged 1 commit into from
Apr 1, 2020

Conversation

MartijnCuppens
Copy link
Member

It seems #11266 is solved in the meantime and this was causing the inputs to shrink (date & time inputs):
image

@XhmikosR
Copy link
Member

XhmikosR commented Mar 6, 2020

@MartijnCuppens which iOS versions did you test?

iOS >= 10

@mdo
Copy link
Member

mdo commented Mar 6, 2020

Tangent, but saw the comment and figured I'd look up iOS distribution: https://developer.apple.com/support/app-store/. We can probably move to iOS 12+ given the browser share there. v4 covers us on older versions.

@ysds
Copy link
Member

ysds commented Mar 7, 2020

@MartijnCuppens Could you create before and after test cases?

@MartijnCuppens
Copy link
Member Author

Before

ios13:
image
ios12:
image
ios11:
image
ios9:
image

After

ios13:
image
ios12:
image
ios11:
image
ios9:
image

I can't reproduce the initial issue from back in 2013.

@XhmikosR
Copy link
Member

XhmikosR commented Mar 7, 2020

Shouldn't this be also backported?

MartijnCuppens added a commit that referenced this pull request Mar 7, 2020
@MartijnCuppens
Copy link
Member Author

Yes, made a separate PR since reboot changed a lot in v5

@ysds
Copy link
Member

ysds commented Mar 8, 2020

@MartijnCuppens Do you intend that this affect input style with .form-control class?

Before: https://codepen.io/fellows3/pen/BaNmvvN

image

After: https://codepen.io/fellows3/pen/RwPjEeO

image

@MartijnCuppens MartijnCuppens changed the title Remove appearance from date inputs Fix date inputs heights in safari Mar 10, 2020
@MartijnCuppens MartijnCuppens force-pushed the master-mc-remove-appearance-from-date-input branch from a2e903c to 62acca4 Compare March 10, 2020 21:11
@MartijnCuppens
Copy link
Member Author

In that case we should only change the appearance for .form-controls. I now pushed some changes and set the height of the ::-webkit-date-and-time-value pseudo selector to prevent it from collapsing.

scss/forms/_form-control.scss Outdated Show resolved Hide resolved
MartijnCuppens added a commit that referenced this pull request Mar 31, 2020
Remove appearance from date inputs
XhmikosR added a commit that referenced this pull request Apr 1, 2020
Remove appearance from date inputs

Co-authored-by: XhmikosR <xhmikosr@gmail.com>
@MartijnCuppens MartijnCuppens force-pushed the master-mc-remove-appearance-from-date-input branch from 9828643 to ccab761 Compare April 1, 2020 06:25
@MartijnCuppens MartijnCuppens merged commit 6663faa into master Apr 1, 2020
@MartijnCuppens MartijnCuppens deleted the master-mc-remove-appearance-from-date-input branch April 1, 2020 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants