Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop .pre-scrollable class #29135

Merged
merged 2 commits into from
Jul 25, 2019
Merged

Drop .pre-scrollable class #29135

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
771173d
Drop `.pre-scrollable` class
MartijnCuppens Jul 25, 2019
4bfe676
Mention dropped `.pre-scrollable` class in migration guide.
MartijnCuppens Jul 25, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 0 additions & 6 deletions scss/_code.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,9 +38,3 @@ pre {
word-break: normal;
}
}

// Enable scrollable blocks of code
.pre-scrollable {
max-height: $pre-scrollable-max-height;
overflow-y: scroll;
}
1 change: 0 additions & 1 deletion scss/_variables.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1106,4 +1106,3 @@ $kbd-color: $white !default;
$kbd-bg: $gray-900 !default;

$pre-color: null !default;
$pre-scrollable-max-height: 340px !default;
2 changes: 1 addition & 1 deletion site/content/docs/4.3/content/code.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ For example, <code>&lt;section&gt;</code> should be wrapped as inline.

## Code blocks

Use `<pre>`s for multiple lines of code. Once again, be sure to escape any angle brackets in the code for proper rendering. You may optionally add the `.pre-scrollable` class, which will set a max-height of 340px and provide a y-axis scrollbar.
Use `<pre>`s for multiple lines of code. Once again, be sure to escape any angle brackets in the code for proper rendering.

{{< example >}}
<pre><code>&lt;p&gt;Sample text here...&lt;/p&gt;
Expand Down
1 change: 1 addition & 0 deletions site/content/docs/4.3/migration.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@ Changes to Reboot, typography, tables, and more.
- **Todo:** Make RFS enabled by default
- Reset default horizontal `padding-left` on `<ul>` and `<ol>` elements from browser default `40px` to `2rem`.
- Simplified table styles (no more 2px border on `thead > th` elements) and tightened cell padding.
- Dropped `.pre-scrollable` class. [See #29135](https://github.com/twbs/bootstrap/pull/29135)

## Forms

Expand Down