Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop .pre-scrollable class #29135

Merged
merged 2 commits into from Jul 25, 2019
Merged

Conversation

MartijnCuppens
Copy link
Member

@MartijnCuppens MartijnCuppens commented Jul 25, 2019

So that #28917 can be merged. This class is probably not used that much, we don't even use it in our docs ourselves. Custom css can be written to replace this class.

TODO:

  • Document in migration

@MartijnCuppens MartijnCuppens requested a review from a team as a code owner July 25, 2019 16:10
@MartijnCuppens MartijnCuppens added this to Inbox in v5 via automation Jul 25, 2019
@MartijnCuppens MartijnCuppens mentioned this pull request Jul 25, 2019
1 task
v5 automation moved this from Inbox to Approved Jul 25, 2019
@MartijnCuppens MartijnCuppens merged commit 39b88d4 into master Jul 25, 2019
v5 automation moved this from Approved to Shipped Jul 25, 2019
@MartijnCuppens MartijnCuppens deleted the master-mc-drop-pre-scrollable branch July 25, 2019 16:42
@vanillajonathan
Copy link
Contributor

For anyone who relied on this class, here is the CSS code previously used.

.pre-scrollable {
  max-height: 340px;
  overflow-y: scroll;
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
v5
  
Shipped
Development

Successfully merging this pull request may close these issues.

None yet

3 participants