Sass: remove redundant stylelint inline suppressions.

[XhmikosR]

selector-max-universal is set to 1 in our stylelint config upstream BTW.

-rd works fine as long as one clears the local cache folder. But perhaps we should enable it anyway?

[MartijnCuppens]

What is -rd?

[XhmikosR]

--report-needless-disables, --rd

  Also report errors for stylelint-disable comments that are not blocking a lint warning.
  The process will exit with code 2 if needless disables are found.

--report-invalid-scope-disables, --risd

  Report stylelint-disable comments that used for rules that don't exist within the configuration object.
  The process will exit with code 2 if invalid scope disables are found.

[MartijnCuppens]

selector-max-universal is set to 1 in our stylelint config upstream BTW.

Any idea why stylelint isn't failing with the current scss than? We do have more than one universal selector.

[XhmikosR]

We do have more than one universal selector.

In the same selector?

[MartijnCuppens]

Ok, never mind, the documentation states:

Limit the number of universal selectors in a selector.

I thought it was about the global number of universal selectors, now I get it why that statement was moot.

-rd works fine as long as one clears the local cache folder.

What happens if the local cache folder isn't cleared? Can we get false results?

[XhmikosR]

Yeah, I definitely get false results. I mean, stuff that can be removed but are not flagged as such. But on CI this will fail properly.

[ysds]

Isn't a space necessary before the --report-needless-disables?

I tried run npm run lint after fix this and remove my .cache folder, but stylelint reported a lot of errors:

and more.

[ysds]

refs: stylelint/stylelint#4203

[XhmikosR]

Ooops, the space should be there.

[XhmikosR]

But yeah, I see now the issue, hence why i hadn't enabled it before :)

I'll drop it for now.