-
-
Notifications
You must be signed in to change notification settings - Fork 78.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sass: remove redundant stylelint inline suppressions. #29427
Conversation
What is |
|
Any idea why stylelint isn't failing with the current scss than? We do have more than one universal selector. |
In the same selector? |
Ok, never mind, the documentation states:
I thought it was about the global number of universal selectors, now I get it why that statement was moot.
What happens if the local cache folder isn't cleared? Can we get false results? |
Yeah, I definitely get false results. I mean, stuff that can be removed but are not flagged as such. But on CI this will fail properly. |
91bd5c0
to
82935d2
Compare
package.json
Outdated
@@ -24,7 +24,7 @@ | |||
"css": "npm-run-all css-compile css-prefix css-minify", | |||
"css-compile": "node-sass --output-style expanded --source-map true --source-map-contents true --precision 6 scss/ -o dist/css/", | |||
"css-lint": "npm-run-all --continue-on-error --parallel css-lint-*", | |||
"css-lint-stylelint": "stylelint \"**/*.{css,scss}\" --cache --cache-location .cache/.stylelintcache", | |||
"css-lint-stylelint": "stylelint \"**/*.{css,scss}\" --cache --cache-location .cache/.stylelintcache--report-needless-disables", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
refs: stylelint/stylelint#4203
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ooops, the space should be there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But yeah, I see now the issue, hence why i hadn't enabled it before :)
I'll drop it for now.
91b6ac6
to
770db73
Compare
selector-max-universal
is set to1
in our stylelint config upstream BTW.-rd
works fine as long as one clears the local cache folder. But perhaps we should enable it anyway?