Enable eslint no-console rule except for build directory #29585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pwolaq
changed the title
|
I'll manually backport this to v4-dev. |
XhmikosR
added a commit
that referenced
this pull request
Oct 25, 2019
lucanos
pushed a commit
to lucanos/bootstrap
that referenced
this pull request
Oct 27, 2019
XhmikosR
added a commit
that referenced
this pull request
Oct 28, 2019
XhmikosR
added a commit
that referenced
this pull request
Nov 1, 2019
XhmikosR
added a commit
that referenced
this pull request
Nov 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #29583
I have added the following config to the global
.eslintrc.jsonfile:As a result there were few errors inside
builddirectory, which are now fixed by disabling this rule inside directory.