Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V4: Add :disabled for disabled fieldset #29762

Merged
merged 2 commits into from Nov 28, 2019

Conversation

@ysds
Copy link
Member

ysds commented Nov 28, 2019

This PR is #29740 for v4, targets the v4-dev-xmr branch.

Before (4.4.0): https://codepen.io/fellows3/pen/LYYwejp
After: https://codepen.io/fellows3/pen/pooMpWQ

@ysds ysds requested a review from twbs/css-review as a code owner Nov 28, 2019
@ysds ysds added css v4 labels Nov 28, 2019
@XhmikosR

This comment has been minimized.

Copy link
Member

XhmikosR commented Nov 28, 2019

@ysds does this apply to master too or only v4?

@ysds

This comment has been minimized.

Copy link
Member Author

ysds commented Nov 28, 2019

Only v4!

@XhmikosR

This comment has been minimized.

Copy link
Member

XhmikosR commented Nov 28, 2019

Hmm, then we need @MartijnCuppens and @mdo to review too.

@XhmikosR XhmikosR added this to Inbox in v4.4.1 Nov 28, 2019
@MartijnCuppens

This comment has been minimized.

Copy link
Member

MartijnCuppens commented Nov 28, 2019

If we're going to include this in 4.4.1, we'll need to update our blogpost a bit

@XhmikosR

This comment has been minimized.

Copy link
Member

XhmikosR commented Nov 28, 2019

If you guys think it's safe, we can include it since have the patch ready.

@MartijnCuppens

This comment has been minimized.

Copy link
Member

MartijnCuppens commented Nov 28, 2019

I think we're save with this one

@MartijnCuppens

This comment has been minimized.

Copy link
Member

MartijnCuppens commented Nov 28, 2019

I've added this in twbs/blog#123

@XhmikosR XhmikosR merged commit 66dfbc4 into v4-dev-xmr Nov 28, 2019
9 checks passed
9 checks passed
Node 6
Details
Node 6
Details
Node 8
Details
Node 8
Details
Node 12
Details
Node 12
Details
LGTM analysis: JavaScript No code changes detected
Details
bundlesize Total bundle size is 173.86KB/176KB (-null)
Details
coverage/coveralls Coverage remained the same at 91.538%
Details
@XhmikosR XhmikosR deleted the v4-dev-disabled-fieldset branch Nov 28, 2019
@XhmikosR XhmikosR moved this from Inbox to Shipped in v4.4.1 Nov 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
v4.4.1
  
Shipped
3 participants
You can’t perform that action at this time.