Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary comma in 'All colors' #30010

Merged
merged 4 commits into from Jan 16, 2020
Merged

Remove unnecessary comma in 'All colors' #30010

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9a61dae
Remove unnecessary comma in 'All colors'
TyMick Jan 13, 2020
0d8c4b8
Merge branch 'master' into patch-1
XhmikosR Jan 13, 2020
52cb9ab
Update theming.md
XhmikosR Jan 16, 2020
2f04b59
Merge branch 'master' into patch-1
XhmikosR Jan 16, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion site/content/docs/4.3/getting-started/theming.md
View file
Open in desktop
Expand Up @@ -280,7 +280,7 @@ Many of Bootstrap's various components and utilities are built through a series

### All colors

All colors available in Bootstrap 5, are available as Sass variables and a Sass map in `scss/_variables.scss` file. To avoid increased file sizes, we do not create classes for each of these variables.
All colors available in Bootstrap 5 are available as Sass variables and a Sass map in `scss/_variables.scss` file. To avoid increased file sizes, we do not create classes for each of these variables.

Sass cannot programmatically generate variables, so we must manually create them ourselves. We specify the midpoint value (`500`) and use custom color functions to tint (lighten) or shade (darken) our colors via Sass's `mix()` color function. Using `mix()` is not the same as `lighten()` and `darken()`—the former blends the specified color with white or black, while the latter only adjusts the lightness value of each color. The result is a much more complete suite of colors, as [shown in this CodePen demo](https://codepen.io/emdeoh/pen/zYOQOPB).

Expand Down