Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix file input #30086

Merged
merged 1 commit into from
Jan 25, 2020
Merged

Fix file input #30086

merged 1 commit into from
Jan 25, 2020

Conversation

MartijnCuppens
Copy link
Member

@MartijnCuppens MartijnCuppens commented Jan 25, 2020 •
edited
Loading

@XhmikosR
Copy link
Member

When did this break exactly? Just to double check things.

@MartijnCuppens
Copy link
Member Author

MartijnCuppens commented Jan 25, 2020 •
edited
Loading

We switched from a pseudo element button to a .form-file-button and forgot to adjust the documentation here. (#28696)

@XhmikosR
Copy link
Member

Can you check if there are more cases?

@MartijnCuppens
Copy link
Member Author

I did (searched for custom-file occurrences and this was the only place we missed)

@XhmikosR XhmikosR merged commit 3350931 into master Jan 25, 2020
@XhmikosR XhmikosR deleted the master-mc-fix-file-input branch January 25, 2020 13:58
@XhmikosR
Copy link
Member

BTW it would be nice if you referenced the commit or PR something broke in the future :)

olsza pushed a commit to olsza/bootstrap that referenced this pull request Oct 3, 2020
@MartijnCuppens @olsza
Fix file input (twbs#30086)
d3ec991
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XhmikosR XhmikosR XhmikosR approved these changes

Assignees
No one assigned
Labels
css no-backport-to-v4 v5
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MartijnCuppens @XhmikosR